Toggle graphs in the training board olena #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tharvik
requested changes
Nov 5, 2024
JulienVig
requested changes
Nov 12, 2024
| }, | ||
| }); | ||
|
|
||
| expect(wrapper.findAll("#mapHeader li")).toHaveLength(3); | ||
| const listItems = wrapper.findAll("#mapHeader li"); | ||
| expect(listItems.length === 0 || listItems.length === 3).toBe(true); |
There was a problem hiding this comment.
Only one length should be expected (is the advanced information open or closed by default?).
Can you break this down into two assertions: one when the length is expected to be 0 and another when the length should be 3? You can use cypress' .click() to toggle the advanced information.
There was a problem hiding this comment.
This test is designed to validate the Training Logs section, which has been removed. Therefore, the test should only pass when the length is 0. However, does it make sense to keep this test at all, considering there is essentially nothing left for it to verify?
There was a problem hiding this comment.
Indeed you can remove it altogether!
JulienVig
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client-side
Additions & Modifications:
Enhanced DropdownCard Component:
Refinements in the Training Information Section:
Removed Training Logs from Training Information: